ProtonMail / ProtonMail/WebClients
Vulnerability in WebClients project
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.6k
- Forks
- 715
- PR merge metrics
- No merged PRs in 30d
Description
While working in WebClients project, I found that the parser does not properly restrict entity expansion when handling XML files containing DOCTYPE declarations. The issue exists in the entity replacement logic, which allows unlimited entity expansion without limiting execution cost or output size.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the parser's entity replacement logic for XML files containing DOCTYPE declarations, using the linked CVE report for context. Identify the relevant parser entry point and existing tests, then verify that entity expansion has bounded execution cost and output size without breaking supported XML handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, xml
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100