ProtonMail / ProtonMail/WebClients

Proton Pass Web Extension - Autofill keyboard shortcut contribution

Open
#453 9 comments 13 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.6k
Forks
715
PR merge metrics
No merged PRs in 30d

Description

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

Hello, this is not a feature request exactly but relates to https://protonmail.uservoice.com/forums/953584-proton-pass/suggestions/48140276-keyboard-shortcuts.

I want to make a PR to add a keyboard shortcut for autofilling in the Proton Pass web extension. But before I get started I wanted to check if the Proton team is happy for me to proceed? 😊

I am thinking of using Cmd/Ctrl+Shift+L as the default shortcut which is similar to other password managers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. First wait for Proton team confirmation on whether to proceed and the proposed Cmd/Ctrl+Shift+L shortcut; then locate the web extension's existing keyboard-shortcut or autofill entry point. Done is not defined beyond an accepted contribution, so confirm scope and validation with maintainers.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.