ProtonMail / ProtonMail/WebClients

Workaround for accepting `.asc` on iOS

Open
#413 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.6k
Forks
715
PR merge metrics
No merged PRs in 30d

Description

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

Currently, only public keys in .txt can be uploaded in web app on iOS. As a result, one has to manually add the suffix to every .asc key received.

https://github.com/ProtonMail/WebClients/blob/2a45b4b7d8c34106505ff4d090b0c1115657dd89/packages/pass/components/Import/ImportForm.tsx#L146-L153

Are there plans to work round this limitation?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at packages/pass/components/Import/ImportForm.tsx#L146-L153 and inspect how the web app filters or accepts public-key filenames on iOS. Verify the behavior with an .asc key in the iOS upload flow, and consider the issue complete when such keys can be selected without manually renaming them.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, mobile-dev
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.