ProtonMail / ProtonMail/WebClients

Why some webpage's favicon don't appear in proton Pass?

Open
#408 4 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.6k
Forks
715
PR merge metrics
No merged PRs in 30d

Description

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

I tried to file a report, but I have no idea where the "contact" button is. So I'm doing it here.

Why some webpages, like xdaforums.com or crypt.ee don't appear with favicons inside proton pass?
Screenshot From 2024-09-20 09-08-58
w h y ? my OCD hates it! >n<

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, reproduction steps, or entry point is identified in the issue. Start by reproducing the missing favicon behavior for xdaforums.com and crypt.ee in Proton Pass, then trace the web client favicon handling; done means the affected webpages display their favicons or the limitation is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.