ProtonMail / ProtonMail/WebClients

Follow system theme

Open
#396 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5.6k
Forks
715
PR merge metrics
No merged PRs in 30d

Description

We are happy to answer your questions about the code or discuss technical ideas.

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

This might be a regression. Protonmail doesn't detect system theme on Chromium.

  • Chromium > Settings > Dark theme
  • Check for Sec-CH-Prefers-Color-Scheme: dark http header in https://deviceinfo.me
  • Protonmail > Settings > Theme > Sync with system
  • Expected: display site in dark theme
  • Result: site displayed in light theme

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Chromium dark-theme steps described in the issue, including checking the Sec-CH-Prefers-Color-Scheme header and ProtonMail's “Sync with system” setting. Trace the frontend system-theme detection path; done means Chromium users with a dark system theme see the site in dark mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.