ProtonMail / ProtonMail/WebClients
ProtonPass: A password form within `<dialog />` (modal) element overlays the floating pop-up.
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.6k
- Forks
- 715
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- This isn't a feature request
- This is not a report about my app not working as expected
I am facing the following issue using ProtonPass, when trying to auto-fill a form in a <dialog/> modal. Here is a picture for reference:
P.S.: this particular example is using daisyUI's modal component, so it might effect a wide selection of websites.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the ProtonPass autofill behavior in the daisyUI dialog modal linked in the issue, then trace the frontend code responsible for the floating popup and modal layering. Done means the password form and popup display correctly together when the form is inside a
modal.Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100