ProtoDef-io / ProtoDef-io/node-protodef
encode buffers as hex instead of array of bytes in json tests ?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 35
- Forks
- 25
- Avg merge
- 4d 3m
- Merged PRs (30d)
- 2
Description
new Buffer("381905","hex") instead of new Buffer([0x38,0x19,0x05],"hex")
Kind of shorter and clearer.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the JSON tests referenced by the issue and locate the buffer values written as arrays of bytes. Replace those representations with hexadecimal buffer strings, then run the existing test suite. Done means the tests still pass with the shorter, clearer buffer syntax.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100