ProjectTorreyPines / ProjectTorreyPines/IMASdd.jl

Default setting in imas2json takes forever to save

Open
#25 3 comments 0 reactions 1 assignee View on GitHub

@orso82 is already working on this.

Since Jul 25, 2024.

Dominant language
Julia
Stars
9
Forks
4
PR merge metrics
No merged PRs in 30d

Description

https://github.com/ProjectTorreyPines/IMASDD.jl/blob/7784a05b23b99b3d859c1fbc335dd0562049ffe8/src/io.jl#L347

The default of freeze=true with strict=false causes all the expressions to evaluate. A sparse IDS with freeze=false, strict=true can be saved rather quickly. A sparse IDS that tries to evaluate every expression while saving takes forever to save. I recommend changing the default behavior as the case for just dumping what's in the IDS to disk makes more sense. After all, that sparse dataset can be picked back up easily with json2imas and the expressions can then be evaluated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.