ProjectEvergreen / ProjectEvergreen/wcc

expand (no-op) support of DOM shim for DOM traversal methods

Open
#37 3 comments 0 reactions 1 assignee View on GitHub

@thescientist13 is already working on this.

Since May 27, 2022.

  • #233 by @thescientist13 — merged
feature question
Dominant language
JavaScript
Stars
126
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Type of Change

  • New Feature Request

Summary

Tracking a number of items that I think the DOM shim should be able to support, though I'm not sure how feasible / realistic any of them are, so will need to do some discovery of what makes sense to fall "in bounds" for SSR, short of just becoming a headless browser.

Details

Not sure how many of these can / should be supported, but some of them at least, if not at least for no-ops

  • parentNodes
  • querySelector / querySelectorAll
  • getElementBy[Id|ClassName|TagName|...]
  • Node <> Element <> HTMLElement (ensure proper inheritance hierarchy)

Questions

  • Is appendNode implemented correctly?
  • Use ASTs in DOM shim (?)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.