Project60 / Project60/org.project60.sepapp
On Event SEPA payment processor (classic version) produces extra (erroneous) financial_transactions
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 5
- Forks
- 7
- Avg merge
- 15d 12h
- Merged PRs (30d)
- 1
Description
In #18 we fixed that OOF memberships, created an erroneous financial transaction.
At the end the issue was not solved for events.
I had already the following findings:
However for events this problem still remains. Because the parameter is_paylater is set false, a payment is created here:
https://github.com/civicrm/civicrm-core/blob/48e6e28f1af3023577e16437620fdf751c005d0b/CRM/Contribute/BAO/Contribution.php#L3183
My feelings say, that there need to be changes in the BAO/Contribution.php . But I'm still not very confident, with the code there, as it very long and complex.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with CRM/Contribute/BAO/Contribution.php at the linked locations around lines 2950 and 3183, and trace the event payment path when is_paylater is false. Reproduce an event SEPA payment and compare its financial transactions with the expected result; done means the erroneous extra transaction is no longer created.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- payments
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100