Project60 / Project60/org.project60.banking
Account Lookup Analyser reduces probability because of orphaned accounts
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
After permanently deleting a contact, it's BankAccounts are not deleted and get orhpaned (contact_id of BankAccount is NULL). As I understand this post that's the intended behaviour.
The Account Lookup Analyser (in combination with a matcher plugin) creates suggestions with a probability according to the CiviBanking setting. This probability is reduced in case there is more than one contact holding the matched account. This even happens, if the additional account is orphaned.
It could be an option to make the Account Lookup Analyser more robust against orhpaned accounts.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Account Lookup Analyser and the matcher-plugin logic that calculates probability from multiple contacts holding an account. Trace how accounts with a NULL contact_id are included, then clarify whether orphaned accounts should be ignored unconditionally or through an option. Done means the intended behavior is implemented and verified for orphaned and non-orphaned accounts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100