Project60 / Project60/org.project60.banking
Bug: Values in JavaScript objects are not escaped correctly in templates
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
For some transactions, I write the campaign title to btx.source via lookup action.
For a campaign title that contained quotation marks, I got a syntax error in the JavaScript code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at templates/CRM/Banking/PluginImpl/Matcher/DefaultOptions.suggestion.tpl#L302-L304, where the campaign title is written into the JavaScript object. Inspect how quotation marks are handled, then verify with a title containing quotation marks that the generated JavaScript remains valid and btx.source receives the full title.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 67/100