Project60 / Project60/org.project60.banking
A matched contribution's receive_date should be set to value_date instead of booking_date
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
According to #409 a matched contribution's receive_date is set to booking_date. However, the booking_date is not necessarily the date when the contribution is received. That's the value_date.
At least in Germany on the donation receipt we have to print the value_date and not the booking_date as the contribution's date.
So my suggestion would be to set the contribution's receive_date to the transaction's value_date instead of the booking_date.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the matched-contribution handling described in the issue and inspect where receive_date is assigned from the transaction. Compare booking_date with value_date, then verify that matched contributions use value_date so donation receipts show the contribution's received date correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, payments
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100