Project60 / Project60/org.project60.banking
Existing contributions matcher: Partial and incorrect payments are closing existing contributions
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
Problem: A payment with an amount greater than zero, that is registered by civiBanking, automatically closes an existing contribution, no matter if the payment amount matches the contribution amount or not. The status of the contribution is automatically set to "completed".
This is especially problematic if the payment is not a donation, but corresponds to e.g. an event fee or a membership fee.
We have attached 2 patches, that have basically fixed the Problem for us and that we would kindly ask for to be reviewed.
These patches were created during CiviSprint Leipzig 2023
Similar issue from 2020: https://github.com/Project60/org.project60.banking/issues/298
civibanking_partial_payment_defaultOptionMatcher.patch
civibanking_partial_payment_ExistingContributionMatcher.patch
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing civibanking_partial_payment_defaultOptionMatcher.patch and civibanking_partial_payment_ExistingContributionMatcher.patch, then compare their intended behavior with issue #298. Verify the matcher distinguishes matching contribution amounts from partial or non-donation payments, and confirm that incorrect matches no longer set contributions to completed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- payments
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100