Project60 / Project60/org.project60.banking

Only set bank account reference matching probability when contact is not found in other ways

Open
#397 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

Context
CiviBanking now contains an option to set probability of the matched contact when the contact is found based on the bank account.

At Velt bank accounts are stored at different contacts (e.g. members of houdsholds, or because someone has used his private bank account for local chapter businesses. Meaning that bank account is also stored at the local chapter in CiviCRM.

Original issue

Some payments where automatically matched against wrong contacts because of this mix up of bank accounts.
This issue is solved by lowering the bank account reference matching probability setting (we have set it at 0.9)

New issue

Contacts found based on their sepa mandate or based on a number in the purpose field. Are also set to 0.9 probability because of the matching on bank account. However in those case we are sure because the Sepa Mandate Reference is leading.

Solution

Only set the probability for found contacts based on the bank account when they are not already found in different ways.

I will soon post a pull request fixing this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named in the issue. Trace the payment matching flow for SEPA mandates, purpose-field numbers, and bank-account matches, then verify that bank-account probability is changed only when no other matching method found the contact; add or update coverage for these cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.