Project60 / Project60/org.project60.banking

Double underscore is reserverd

Open
#388 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

FILE: org.project60.banking/CRM/Banking/PluginModel/Base.php
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 67 | WARNING | Method name "CRM_Banking_PluginModel_Base::__setDAO" is discouraged; PHP has reserved all method
    |         | names with a double underscore prefix for future use.
----------------------------------------------------------------------------------------------------------------------

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with org.project60.banking/CRM/Banking/PluginModel/Base.php at line 67 and inspect how CRM_Banking_PluginModel_Base::__setDAO is referenced. Confirm the intended rename or replacement from the surrounding class context, update affected references, and rerun the PHP lint or coding-standard check until the double-underscore warning is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.