Project60 / Project60/org.project60.banking
Search / filter list of statements not working
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
Attempting to search or filter the list of statements ("Include completed statements", filter by bank account, filter on date) does not work because the form submission URL is broken.
I found a quick fix which is simply to change the form method from GET to POST, which works absolutely fine. Longer-term, it may be better to use a CiviCRM Form object to render the form rather than code manually in the template?
Anyway, changing line 3 of templates/CRM/Banking/Page/Statements.tpl as follows fixes the issue:
<form action="" method="get">
change to:
<form action="" method="post">
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with templates/CRM/Banking/Page/Statements.tpl, especially the form on line 3, and inspect how the statements page receives filter submissions. Verify the form behavior for completed statements, bank account, and date filters; done means each filter submits successfully and returns the expected statement list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100