Project60 / Project60/org.project60.banking

Improve Membership Matcher

Open
#343 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

We want to add the following (configurable) options to the membership matcher:

  1. use the financial type set in the membership type for the contribution that's already there
  2. restrict proposed memberships by status
  3. improve the display of the last paid membership contribution, which is confusing because it looks like it's the proposed new one.
  4. Add a multi_match_penalty configuration, to rate down multiple matches - useful when using auto-exec.
  5. add debug logging

Obviously these changes need to be downward compatible.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the membership matcher and its existing configuration and contribution display logic. Review how proposed memberships are selected, then define backward-compatible behavior and tests for status restrictions, contribution display, multi_match_penalty, and debug logging.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.