Project60 / Project60/org.project60.banking

Default Matcher: JavaScript syntax errors with line breaks in propagated fields

Open
#340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

When propagating fields containing line breaks to contributions with the Default Matcher plugin, the Matcher will not work anymore due to an Uncaught SyntaxError: Invalid or unexpected token caused by line breaks in the field contents not being escaped correctly.

E.g. import a transaction with line breaks in the purposefield, configure the default matcher to propagate the purpose field to the contribution's note field, and analyse the transaction. Note that the Matcher UI is not working anymore

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by importing a transaction whose purpose contains line breaks, configuring the Default Matcher to propagate purpose to the contribution note, and analysing the transaction. Start with the Default Matcher plugin and Matcher UI involved in that flow. Done means the Matcher UI remains usable and the propagated field no longer causes a JavaScript syntax error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.