Project60 / Project60/org.project60.banking

"Bank Account Ownership Conflicts" finds deleted contacts

Open
#338 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

Current behaviour:

"Bank Account Ownership Conflicts" doesn't take care of deletion of contacts.
E.g. one contact is active, one is already deleted: Both are displayed as duplicates.

When you try to merge them (with the button), the following message is displayed:
"Cannot merge because one contact (ID 160064) has been deleted."

Expected beaviour:

"Bank Account Ownership Conflicts" should exclude deleted contacts, when searching for duplicate IBAN entries.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of “Bank Account Ownership Conflicts” and the duplicate IBAN search described in the issue. Confirm how deleted contacts are included, then verify that the conflict results exclude them and that active duplicate contacts are still reported.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.