Project60 / Project60/org.project60.banking
Contribution notes generated twice with Default matcher
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
Since the Default matcher calls Contribution.create twice when the user adds new contributions with it (first, with is_test=1 and again when confirming the suggestion), the CiviCRM API will create two Note objects, when the note parameter is present (e.g. via value propagation).
The Default matcher should exclude the note parameter when first creating new contributions with is_test=1 and only let the API create a Note object when the user confirms the suggestion.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Default matcher and its two Contribution.create calls, then trace how the CiviCRM API handles the note parameter during the is_test=1 request and confirmation. Verify that the test request does not create a Note while the confirmed contribution still does when note is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100