Project60 / Project60/org.project60.banking
Proper use option values
Open
Nobody has claimed this yet.
documentation
enhancement
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
- Instead of using the id's of the civicrm_option_value directly, it would be safer to use the value field.
- civicrm_banking.plugin_types and civicrm_banking.plugin_classes seems to be switched.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the uses of civicrm_option_value and the civicrm_banking.plugin_types and plugin_classes fields. Confirm where option IDs are used instead of the value field and where the two fields are switched; the issue is done when those mappings use the intended values and the fields are no longer reversed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100