DefaultOptions matcher & contribution status override

Hello @bjendres , a quick clarification on the DefaultOptions matcher, if you like:

Some clients of mine asked me to be able to override the contribution status when they are doing a manual processing of a transaction.

Currently, even if you do declare the contribution status_id on the failsafe/default/manual rule, because of those 2 entries:

• https://github.com/Project60/org.project60.banking/blob/master/extension/CRM/Banking/PluginImpl/Matcher/DefaultOptions.php#L143
  and
• https://github.com/Project60/org.project60.banking/blob/master/extension/CRM/Banking/PluginImpl/Matcher/DefaultOptions.php#L147

the contribution will be either saved as 'Completed' or 'Cancelled'. Shouldn't DefaultOptions matcher be able to check if there is a variable that overrides the internal status assignment ?

On the other hand, we could use the postprocessor to re-update the contribution based on the rule but that would create some overhead.

I am just not sure what should be the proper approach. In case the ideal thing would be to expand the 'DefaultOptions' matcher to adapt to this behaviour, I would gladly create a PR for that.

Kind regards,
Vangelis

Start in extension/CRM/Banking/PluginImpl/Matcher/DefaultOptions.php, especially the referenced lines 143 and 147, and trace how manual, default, and failsafe rules assign contribution status. Done means determining and implementing the agreed behavior for an explicitly declared contribution status without the matcher forcing Completed or Cancelled.