Project60 / Project60/org.project60.banking
CiviBanking: Create Membership Contribution matcher broken in CiviCRM 5.20.0
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
How to reproduce
- Install CiviCRM version 5.20.0
- Set under localisation --> Languages, Currency, Localisation --> Decimal Separator to ','
- Install latest version of Banking and configure an importer
- Configure a Create Membership Matcher
- Setup a contact in CiviCRM with a membership
- Create a bank file with a transaction for a membership payment
- Import and analyze this file. Banking suggests to create a membership payment. Press confirm
Actual Results
An error message is shown and no contribution is created.
Expected result
A contribution is created and linked to the membership.
Cause of the problem
This is caused because the amount is not converted to float or to a localized value.
See: https://github.com/Project60/org.project60.banking/blob/master/extension/CRM/Banking/PluginImpl/Matcher/Membership.php#L96
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CRM/Banking/PluginImpl/Matcher/Membership.php around line 96, then reproduce the import using CiviCRM 5.20.0 with a comma decimal separator and a Create Membership Matcher. Confirm the amount handling during membership-payment confirmation and verify that the contribution is created and linked to the membership.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, payments
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100