Project60 / Project60/org.project60.banking
Give API transaction analyser a max execution time
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
API transaction analyser (civicrm_api3_banking_transaction_analyseoldest) currently has an argument to parse a number of transactions, started by the oldest one (value_date). This can potentially run into problems with larger amounts of transactions and a badly set PHP execution time when called from Cron.
Instead it would make sense to change this to an execution time, and respect the php max_execution_time as well.
civicrm_api3_banking_transaction_analyseoldest should be extended to use seconds as an alternate parameter. The parameter should be in seconds, and shall not exceed the php max_execution_time configured.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the civicrm_api3_banking_transaction_analyseoldest API entry point and inspect how its transaction-count argument currently controls processing. Check how PHP max_execution_time is exposed in this execution context. Done means accepting a seconds parameter and ensuring it never exceeds the configured PHP execution limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100