Project60 / Project60/org.project60.banking
viewing a processed transaction does wrongly allow to Analyse again
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 22
- Forks
- 45
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 7
Description
So I'm shooting from the hip, so I'm not sure if it's a bug or me that misuse the tool:
When reviewing a processed transaction 42:
/civicrm/banking/review?id=42
it does offer to re-analyse the transaction, but the result is:
[values] => Array
(
[payment_count] => 1
[processed_count] => 0
[skipped_count] => 1
[time] => 0
[timed_out] => 0
)
ie it does skip an already processed transaction. I'm not sure what processed transaction means yet, but it should either disable the button or properly re-analyse the transaction
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior at /civicrm/banking/review?id=42 for a processed transaction and inspect the review and analysis flow that controls the action. Done means the interface no longer offers an invalid re-analysis, or re-analysis processes the transaction instead of reporting processed_count as 0 and skipped_count as 1.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100