Project60 / Project60/org.project60.banking

Review Bank Page Issue on Analyse (again) button

Open
#190 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

enter image description here
When I click Analyse (again) button on the review page i.e.(civicrm/banking/review?s_list=45)
I get 500 service unavailable error in console
enter image description here

 https://www.example.com/civicrm/ajax/rest 500 (Service unavailable (with message))
  send @ jquery.js:9664
  ajax @ jquery.js:9215
  (anonymous) @ crm.ajax.js?p52hox:143
  CRM.api @ crm.ajax.js?p52hox:152
  analysePayment @ review?s_list=45:752 
  onclick @ review?s_list=45:685

The code at analysePayment@review?s_list=45:752 is

  CRM.api('BankingTransaction', 'analyselist', query,
    {success: function(data) {
    console.log(data);
        if (!data['is_error']) {
          // remove 'execute' bit from URL before reload
          var newURL = window.location.href.replace(reload_regex, '');
          if (window.location.href == newURL) {
            window.location.reload(false);
          } else {
            window.location = newURL;
          }
        } else {
          cj('<div title="Fout"><span class="ui-icon ui-icon-alert" style="float:left;"></span>' + data['error_message'] + '</div>').dialog({
            modal: true,
            buttons: {
              Ok: function() {
                window.location = window.location.href.replace(reload_regex, '');
              }
            }
          });
        }
      }
    }
  );

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the review page URL civicrm/banking/review?s_list=45 and the analysePayment call shown at review?s_list=45:752. Reproduce the Analyse (again) action and inspect the CRM.api request to BankingTransaction, 'analyselist', along with the 500 response. Done means the action no longer returns a Service unavailable error and the review page continues its intended reload or error handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, php
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.