Project60 / Project60/org.project60.banking

Warnings for bank reference normalisation

Open
#155 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
22
Forks
45
Avg merge
3d 15h
Merged PRs (30d)
7

Description

If you have the bank reference normalisation turned on, you'll get the following warnings:

Warning: include(packages/php-iban-1.4.0/php-iban.php): failed to open stream: No such file or directory in CRM_Banking_BAO_BankAccountReference::normalise() (line 105 of /var/www/vhosts/someclient/httpdocs/dev/public/sites/default/files/civicrm/ext/org.project60.banking/CRM/Banking/BAO/BankAccountReference.php). Warning: include(): Failed opening 'packages/php-iban-1.4.0/php-iban.php' for inclusion (include_path='/var/www/vhosts/someclient/httpdocs/dev/public/sites/default/files/civicrm/ext/org.project60.bic/:/var/www/vhosts/someclient/httpdocs/dev/public/sites/default/files/civicrm/ext/org.project60.banking/:/var/www/vhosts/someclient/httpdocs/dev/public/sites/default/files/civicrm/ext/de.systopia.config/:.:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm/packages:.:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm/packages:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm/vendor/tecnickcom:/var/www/vhosts/someclient/httpdocs/dev/public/sites/all/modules/civicrm/vendor/phpseclib/phpseclib/phpseclib:.:') in CRM_Banking_BAO_BankAccountReference::normalise() (line 105 of /var/www/vhosts/someclient/httpdocs/dev/public/sites/default/files/civicrm/ext/org.project60.banking/CRM/Banking/BAO/BankAccountReference.php).

Something's not working there...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in CRM/Banking/BAO/BankAccountReference.php around line 105 and reproduce the warnings with bank reference normalisation enabled. Check how the php-iban package is expected to be made available to the extension. Done means normalisation no longer emits the missing-file include warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
payments
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.