Project-MONAI / Project-MONAI/monai-deploy-app-sdk

Improve the description of -l option

Open
#64 1 comment 0 reactions 1 assignee View on GitHub

@gigony is already working on this.

Since Aug 25, 2021.

enhancement
Dominant language
Python
Stars
138
Forks
70
PR merge metrics
No merged PRs in 30d

Description

If we add logging option -l DEBUG to the monai-deploy package command, it would affect only for packager module (it would show the messages during executing docker build command), not app itself.

However, it is possible that the user may think that specifying -l DEBUG would make App's default logging level to DEBUG when it's not.

It is good to improve the description of -l option.

Since -l option is from main CLI parser(monai/deploy/cli/main.py) that packager parser(monai/deploy/packager/package_command.py) cannot control, we may need to clarify it in main CLI parser's description of -l option or in the documentation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.