Project-MONAI / Project-MONAI/model-zoo

Use Enum class to define hard code strings for CI tests

Open
#49 0 comments 0 reactions 1 assignee View on GitHub

@yiheng-wang-nv is already working on this.

Since Jul 11, 2022.

Dominant language
Python
Stars
338
Forks
106
No merged PRs in 30d

Description

So far, we use hard code strings such as "network_def", "configs/metadata.json" and "model_info.json" in ci tests. These strings are derived according to the current folder structure of this repo and the bundle specification.
If there are some changes in the future, it's hard to modify these strings. Using Enum class to maintain these strings is a better choice, we can do sth like in MONAI:

https://github.com/Project-MONAI/MONAI/blob/dev/monai/utils/enums.py

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.