Project-MONAI / Project-MONAI/model-zoo

logging configuration

Open
#322 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
338
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Currently, bundles usually leverage this line config to run with correct logging:
https://github.com/Project-MONAI/model-zoo/blob/dev/models/spleen_ct_segmentation/configs/logging.conf#L11
Please show the recommendation change or how to update the existing bundles?
CC @yiheng-wang-nv .

(from https://github.com/Project-MONAI/MONAI/pull/6051#issuecomment-1445631476)

with the StatsHandler update, configs/logging.conf (which is mainly used to add a stdout handler to the root logger) can be removed. But all the StatsHandler will need a name=a_logger_name to log to stdout. configs/logging.conf is still useful for the other log handling use cases such as adding a logging.FileHandler

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with models/spleen_ct_segmentation/configs/logging.conf and inspect the existing bundle configurations that use configs/logging.conf or StatsHandler. Determine which bundles need named StatsHandler loggers and which still need file-handler configuration; done means the affected bundles have updated recommendations and no longer depend on logging.conf solely for stdout.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
observability
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.