Project-MONAI / Project-MONAI/MONAI

Update Typing in Code to Remove Ignore Annotation

Open
#8,379 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
8.7k
Forks
1.6k
Avg merge
5d 1h
Merged PRs (30d)
20

Description

Is your feature request related to a problem? Please describe.
There are a lot of annotations in the code for disabling type checking by mypy and pytype. Some of these are unavoidable where untyped code is used, but in many places this is due to improper types being used.

Describe the solution you'd like
At some point the codebase should be reviewed to identify where better type checking can be done and remove these annotations.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by inventorying the mypy and pytype ignore annotations across the codebase and identify cases caused by improper types rather than unavoidable untyped code. Done means the unnecessary annotations are removed and type checking still passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.