Project-MONAI / Project-MONAI/MONAI

AutoencoderKlMaisi input num_splits default value may cause unexpected error

Open
#7,910 0 comments 0 reactions 2 assignees View on GitHub

@dongyang0122 is already working on this.

Since Jul 10, 2024.

Dominant language
Python
Stars
8.7k
Forks
1.6k
Avg merge
5d 1h
Merged PRs (30d)
20

Description

Is your feature request related to a problem? Please describe.
If not given, input num_splits of AutoencoderKlMaisi is set as 16 by default.

This will cause error for input image size like [128,128,128] for a 3 level model.

RuntimeError: Calculated padded input size per channel: (2 x 34 x 34). Kernel size: (3 x 3 x 3). Kernel size can’t be greater than actual input size.

Users may be confused by the error and do not know that the key issue is from num_splits.

Describe the solution you'd like
Change the default value of num_splits to 1, or add docstring or value check to guide the users to tune this parameter.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.