ProfessionalWiki / ProfessionalWiki/WikibaseFacetedSearch
Implement search query quote parsing
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 6
- Forks
- 3
- Avg merge
- 7h 44m
- Merged PRs (30d)
- 2
Description
Follow-up to https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/31
Quote parsing is not implemented yet.
The skipped test added in https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/70 expected quotes around each individual OR value, to allow for multiple quoted values:
haswbfacet:P42="foo bar"|second|"third value"
However, the quote parsing that returns $quotedValue in HasWbFacetFeature::doApply() (via SimpleKeywordFeature) seems to expect quotes for the entire keyword value:
haswbfacet:"P42=foo bar|second|third value"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with issue 31 and the skipped test added in pull request 70. Read HasWbFacetFeature::doApply() and SimpleKeywordFeature to compare the existing $quotedValue handling with the individual-value examples in this issue. Done means the intended quote parsing is implemented and the skipped test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- search
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100