ProfessionalWiki / ProfessionalWiki/WikibaseFacetedSearch
Support more Property types
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 6
- Forks
- 3
- Avg merge
- 7h 44m
- Merged PRs (30d)
- 2
Description
Follow-up to:
- https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/49
- https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/56
AC:
- Determine which Property types should be supported
- Add more Property types for field creation: https://github.com/ProfessionalWiki/WikibaseFacetedSearch/blob/master/src/Persistence/Search/SearchIndexFieldsBuilder.php
- Add more DataValue translations for data indexing: https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/51/files#diff-3111d61a2aef9a5bce15e5497fd8f5e7ef81a793b73186b9f5d4923229b12b62
- Add more Property types for query creation
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked issues 49 and 56, then inspect src/Persistence/Search/SearchIndexFieldsBuilder.php and the DataValue translation changes in pull request 51. Determine the Property types to support and trace the query-creation path. Done means field creation, data indexing, and query creation all handle the selected types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elasticsearch, php
- Domain
- search
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100