ProfessionalWiki / ProfessionalWiki/Maps

Geojson popups should not be editable when not in editing mode

Open
#738 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
78
Forks
65
Avg merge
9h 17m
Merged PRs (30d)
6

Description

Setup
  • Maps version: 9.0.7
  • MW version: 1.38.2 (1b271be)
  • PHP version: 7.4.33 (fpm-fcgi)
Issue

When browsing a GeoJson page and clicking on a marker, a popup appears containing two textareas (for title and description) and a button. This makes sense when in editing mode, but when in reading mode the popup should not be (or appear to be) editable.

GeoJson-Popup

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the GeoJson marker popup in reading mode using the reported Maps and MediaWiki versions, then compare it with editing mode. Trace the popup implementation and its title, description, and button controls; done means the popup is not editable or does not appear editable when editing is disabled, while editing mode remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.