ProfessionalWiki / ProfessionalWiki/Maps
Fix tests on MW 38
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 78
- Forks
- 65
- Avg merge
- 9h 17m
- Merged PRs (30d)
- 6
Description
- Maps\Tests\Integration\DataAccess\GeoJsonFetcherTest::testWhenFileRetrievalFails_emptyJsonIsReturned
LogicException: This ParserOutput contains no text!
/home/runner/work/Maps/Maps/mediawiki/includes/parser/ParserOutput.php:363
/home/runner/work/Maps/Maps/mediawiki/extensions/Maps/src/Presentation/OutputFacade.php:33
/home/runner/work/Maps/Maps/mediawiki/extensions/Maps/src/GeoJsonPages/GeoJsonMapPageUi.php:23
/home/runner/work/Maps/Maps/mediawiki/extensions/Maps/src/GeoJsonPages/GeoJsonContent.php:62
/home/runner/work/Maps/Maps/mediawiki/extensions/Maps/src/GeoJsonPages/GeoJsonContent.php:56
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Maps\Tests\Integration\DataAccess\GeoJsonFetcherTest::testWhenFileRetrievalFails_emptyJsonIsReturned and reproduce the failure on MediaWiki 38. Read the stack-trace path through OutputFacade.php, GeoJsonMapPageUi.php, and GeoJsonContent.php, then confirm the test passes while still returning empty JSON when file retrieval fails.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100