ProfessionalWiki / ProfessionalWiki/Maps

Implement imageBounds to make image layers usable

Open
#651 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
78
Forks
65
Avg merge
9h 17m
Merged PRs (30d)
6

Description

With the mage layers option of leaflet SMW quieris is working in general, I could not find a way to set an image to the correct size or align it somehow so that coordinates make sense.

See this example:
https://maps.extension.wiki/wiki/User:Krabina/ImageLayers
while this is a silly example, image the image being a historical map of Berlin, where actual coordinates would make sense. However, the coordinates displayed to seem to "think" that a world map is shown.

In the leaflet documentation, I found the hint of the imageBounds parameter:
https://leafletjs.com/reference-1.7.1.html#imageoverlay
I guess if this is implemented then there would be an option to align actual coordinates with an image.

In case anyone has better hints on how to make this usable, please feel free to discuss this here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the image-layer implementation and reviewing Leaflet's imageOverlay imageBounds documentation, then compare its behavior with the linked historical-map example. Done should provide a way to set image bounds so image layers can align with real coordinates instead of assuming a world map.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.