ProfessionalWiki / ProfessionalWiki/Maps
Improve default zoom when there are no coordinates
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 78
- Forks
- 65
- Avg merge
- 9h 17m
- Merged PRs (30d)
- 6
Description
Import from https://bugzilla.wikimedia.org/show_bug.cgi?id=57337
You can see the issue here:
http://semantic-mediawiki.org/wiki/Yaron%27s_location
This page calls a template, which calls #display_point - the "coordinates" parameter is set to null, while the "zoom" parameter is set to 7. So, what shows up on the map is a highly-zoomed view of a location somewhere off the coast of Africa. Instead, if the coordinates (or address, etc.) are null, I would think #display_point should ignore the "zoom" parameter, and always set to it the lowest zoom level, i.e. show the whole world.
-- @yaronkoren 2013-11-21 01:35:46 UTC
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior on the linked Yaron's location page and trace the #display_point entry point when coordinates are null and zoom is 7. Confirm the map ignores the supplied zoom in that case and displays the whole-world view, then verify the normal behavior remains unchanged when coordinates are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100