PrismarineJS / PrismarineJS/node-minecraft-protocol
node-minecraft-protocol can throw an unhandled exception when the returned disconnect string is invalid.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
[x] The FAQ doesn't contain a resolution to my issue
Versions
- minecraft-protocol: lastest
- server: vanilla/spigot/paper not vanilla ?
- node: 14
Detailed description of a problem
This line in node-minecraft-protocol can throw an unhandled error when the returned string is not a json or invalid. https://github.com/PrismarineJS/node-minecraft-protocol/blob/ffe912b2fe92f53e595615ad346a0237a9b1edf3/src/client/versionChecking.js#L4
Expected behavior
Better error handling. Maybe emit the raw string instead when the json parsing failed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/client/versionChecking.js at the linked line, where the returned disconnect string is parsed. Reproduce the case with a non-JSON or invalid response and inspect the existing client error behavior. Done means invalid returned strings no longer cause an unhandled exception and the reported error matches the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100