PrismarineJS / PrismarineJS/node-minecraft-protocol
Typo in session object returned after authentication
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
[x] The FAQ doesn't contain a resolution to my issue
Versions
- minecraft-protocol: current
Detailed description of a problem
Microsoft auth returnes a sligthly different session under client.session and on the event 'session' compared with mojang. With microsoft the available profiles property is written availableProfile where mojang has availableProfiles.
Expected behavior
Both objects should look the same.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the Microsoft authentication path that constructs client.session and emits the 'session' event. Compare its profile property with the Mojang session shape, then verify that both returned objects use availableProfiles consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100