PrismarineJS / PrismarineJS/node-minecraft-protocol

`has_fixed` is missing from the dimension field in the `Join Game` client bound packet

Open
#900 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
290
Avg merge
4d 8h
Merged PRs (30d)
7

Description

Versions

  • server: vanilla 1.17.1

Detailed description of a problem

According to https://wiki.vg/Protocol the Join Game packets Dimension Type should include a property fixed_time if the doDayLightCycle is set to false. However there is not such a property in the client packet as of now.

Current code

This is the current output of NMP dimension field.

{
  piglin_safe: { type: 'byte', value: 0 },
  natural: { type: 'byte', value: 1 },
  ambient_light: { type: 'float', value: 0 },
  infiniburn: { type: 'string', value: 'minecraft:infiniburn_overworld' },
  respawn_anchor_works: { type: 'byte', value: 0 },
  has_skylight: { type: 'byte', value: 1 },
  bed_works: { type: 'byte', value: 1 },
  effects: { type: 'string', value: 'minecraft:overworld' },
  has_raids: { type: 'byte', value: 1 },
  logical_height: { type: 'int', value: 256 },
  coordinate_scale: { type: 'double', value: 1 },
  min_y: { type: 'int', value: 0 },
  has_ceiling: { type: 'byte', value: 0 },
  ultrawarm: { type: 'byte', value: 0 },
  height: { type: 'int', value: 256 }
}

Expected behavior

Should include fixed_time.

{
 fixed_time: { type: 'long', value: 123456 }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Join Game client-bound packet entry point and inspect how its dimension field is decoded or represented. Compare the dimension properties with the linked wiki.vg protocol description; done means the field includes fixed_time as a long value when required, with the relevant packet behavior covered by an existing test if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.