PrismarineJS / PrismarineJS/node-minecraft-protocol

Chunk size is *** but only 1 was read && client disconnect with DecoderException

Open
#811 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
290
Avg merge
4d 8h
Merged PRs (30d)
7

Description

[!] The FAQ doesn't contain a resolution to my issue

Versions

  • minecraft-protocol: 6.14.11
  • server: minecraft-protcol
  • node: 10.19.0

Detailed description of a problem

I'm building proxy using minecraft-protocol only. But having 2 troubles. Player everytime kicked with error(without any errors in my proxy process).

image

And 2nd problem is

image

Current code

var server = utils.createServer(downstream, 1, "My shiny proxy")
let client = null

server.on("login", (socket) => {

    var loginPacket = utils.createLoginPacket(server, socket, false, 0, 10);
    var positionPacket = utils.createPositionPacket(0, 100, 0, 0, 0);

    socket.write('login', loginPacket);
    socket.write('position', positionPacket);

    logger.info('Player ' + socket.username + ' logged in.');

    socket.on('packet', (packet, meta) => {

        logger.downstream('Client => Downstream => Upstream => Server');

        utils.emitEvents(socket, meta, packet);

    });

    socket.on('raw', (data, meta) => {

        if(client === null) {

            client = utils.createClient(upstream, socket.username);
            client.on('raw', (data, meta) => {

                socket.write(meta.name, data);

            });
            client.on('packet', (data, meta) => {

                logger.upstream('Client <= Downstream <= Upstream <= Server');

                utils.emitEvents(client, meta, data);

            });

        }
        
        console.log(data)

        client.write(meta.name, data);

    });

    socket.on("message", (packet, message) => {

        if(message.startsWith('/')) {

            logger.data('Player ' + socket.username + ' issued server command: ' + message);

        }

        else {

            logger.data('Player ' + socket.username + ' > ' + message);

        }

    });

    socket.on('end', (reason) => {

        logger.info('Player ' + socket.username + ' disconnected: ' + reason);

    });

});

Expected behavior

Everytime, no matter what, player will be kicked.

Additional context

utils.js ->

var mc = require('minecraft-protocol')

function createJsonMessage(client, sender, message) {

    var msg = {
        translate: "chat.type.text",
        "with": [
            {
                "text": sender
            },
            {
                "text":message
            }
        ]
    };

    return msg

}

function writeJsonMessage(client, sender, message) {

    var msg = createJsonMessage(sender, message)

    client.write("chat", { "message": JSON.stringify(msg) });

}

function emitEvents(client, meta, packet) {

    if(meta.name == "chat") {

        client.emit("message", packet, packet.message);
        client.emit("proxy_packet", packet.message);

    }

}

function createServer(config, maxPlayers, motd) {

    const mcData = require('minecraft-data')(config.version);

    var server = mc.createServer({
        "online-mode": config['online-mode'],
        host: config.host,
        port: config.port,
        maxPlayers: maxPlayers,
        motd: motd,
        version: config.version
    });

    return server;

}

function createLoginPacket(server, client, hardcore, gameMode, viewDistance) {

    const mcData = require('minecraft-data')(server.version);

    var loginPacket = mcData.loginPacket;
    var data = {
        entityId: client.id,
        isHardcore: hardcore,
        gameMode: gameMode,
        previousGameMode: 255,
        worldNames: loginPacket.worldNames,
        dimensionCodec: loginPacket.dimensionCodec,
        dimension: loginPacket.dimension,
        worldName: 'minecraft:overworld',
        hashedSeed: [0, 0],
        maxPlayers: server.maxPlayers,
        viewDistance: viewDistance,
        reducedDebugInfo: false,
        enableRespawnScreen: true,
        isDebug: false,
        isFlat: false,
    };

    return data;

}

function createPositionPacket(x, y, z, yaw, pitch) {

    var data = {
        x: x,
        y: y,
        z: z,
        yaw: yaw,
        pitch: pitch,
        flags: 0x00,
    };

    return data;

}

function createClient(config, username, password) {

    var client = mc.createClient({

        host: config.host,
        port: config.port,
        username: username,
        password: password,

    });

    return client;

}

module.exports = {
    "createJsonMessage": createJsonMessage,
    "writeJsonMessage": writeJsonMessage,
    "emitEvents": emitEvents,
    "createServer": createServer,
    "createLoginPacket": createLoginPacket,
    "createPositionPacket": createPositionPacket,
    "createClient": createClient,
};

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the proxy code in the issue and utils.js, then compare the login, raw packet forwarding, and client/server connection lifecycle against the minecraft-protocol FAQ.md. Reproduce both the chunk-size/DecoderException and disconnect behavior with the listed versions. Done means the proxy forwards the relevant traffic without kicking the player or producing the reported decoder failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.