PrismarineJS / PrismarineJS/node-minecraft-protocol
Cannot handle deserialization error for individual packets
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
Using createClient, when protodef fails to deserialize a packet, the whole client shuts down, and does not allow me to handle expected malformed packets.
I'm not sure if this should be fixed in protodef or nmp.
Versions: minecraft-protocol 1.11.0, protodef 1.6.10, minecraft-data 2.50.0
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure through createClient with an expected malformed packet, then trace whether protodef or nmp terminates the client during deserialization. Determine where an individual packet error is surfaced and verify that the client remains usable while allowing the caller to handle it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100