PrismarineJS / PrismarineJS/node-minecraft-protocol

BungeeCord protocol support

Open
#336 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new feature non-vanilla
Dominant language
JavaScript
Stars
1.4k
Forks
290
Avg merge
4d 8h
Merged PRs (30d)
7

Description

Some kind of protocol support for BungeeCord in node-minecraft-protocol might be interesting.

It sends additional information in the set_protocol packet host field, in the same way as Forge (which instead appends \0FML\0 https://github.com/PrismarineJS/node-minecraft-protocol/issues/114, called this tagHost in https://github.com/PrismarineJS/node-minecraft-protocol/pull/326)

Stumbled across this in Cuberite:

    // BungeeCord handling:
    // If BC is setup with ip_forward == true, it sends additional data in the login packet's ServerAddress field:
    // hostname\00ip-address\00uuid\00profile-properties-as-json
    AStringVector Params;
    if (cRoot::Get()->GetServer()->ShouldAllowBungeeCord() && SplitZeroTerminatedStrings(a_ServerAddress, Params) && (Params.size() == 4))
    {
        LOGD("Player at %s connected via BungeeCord", Params[1].c_str());
        m_ServerAddress = Params[0];
        m_Client->SetIPString(Params[1]);
        m_Client->SetUUID(cMojangAPI::MakeUUIDShort(Params[2]));
        m_Client->SetProperties(Params[3]);
    }

https://github.com/PrismarineJS/node-minecraft-protocol/issues/145 BungeeCord : Fails to parse - closed, not known if still applicable
https://github.com/PrismarineJS/node-minecraft-protocol/issues/302 - a potential use case

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing how node-minecraft-protocol handles the set_protocol host field and the existing Forge tagHost work referenced in issue 114 and pull request 326. Check closed issue 145 and issue 302 for prior context, then clarify the intended BungeeCord behavior and define tests for parsing its additional login data before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.