PrismarineJS / PrismarineJS/node-minecraft-protocol
disable encryption in localhost
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
15:35 < Fenhl> roblabla: For unauthenticated and localhost connections (either of the two conditions is enough for an unencrypted connection) there is no encryption. In that case Login Start is directly followed by Login Success.
Just need to add a check in https://github.com/PrismarineJS/node-minecraft-protocol/blob/a80765549c2cd23099319c450260ad8dffb3f954/src/createServer.js#L128
(might want to check if isException still belong there too)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/createServer.js around line 128 and trace how unauthenticated and localhost connections are handled before encryption. Check whether isException still belongs there, then verify that either condition produces Login Start followed directly by Login Success without encryption.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking, security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100