PrismarineJS / PrismarineJS/node-minecraft-protocol
Potions are causing inventory to crash.
Open
Nobody has claimed this yet.
possible bug
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
Version
- minecraft-protocol: 1.21.1
- when a potion is in the inventory or in a shulker, it causes inventory to crash, specifically a potion of strength. more specifically it throws a Partial Read error in protodef for window_items and slot_items. if you want more info on this go to my numerous reports in the mineflayer discord. I would love to fix this my self but don't quite know where to begin debugging protodef.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the crash with a strength potion in an inventory or shulker, then inspect protodef handling for the window_items and slot_items packets. Compare the failing partial read with a normal inventory update; done means potion-containing inventories parse without an inventory crash or Partial Read error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100