PrismarineJS / PrismarineJS/node-minecraft-protocol
Fix serialization issue in old version for mc server test
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 290
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 7
Description
- mc-server 1.12.2v
kicks clients when invalid credentials:
Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 45. Received -847077210
at new NodeError (node:internal/errors:405:5)
at boundsError (node:internal/buffer:88:9)
at Buffer.readUInt8 (node:internal/buffer:254:5)
at readVarInt (node_modules/protodef/src/datatypes/utils.js:68:22)
at Splitter._transform (src/transforms/framing.js:63:30)
at Transform._write (node_modules/readable-stream/lib/internal/streams/transform.js:153:8)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the mc-server 1.12.2 invalid-credentials test and trace the reported failure through src/transforms/framing.js and node_modules/protodef/src/datatypes/utils.js. Determine why readVarInt receives the negative offset; done means the test no longer throws ERR_OUT_OF_RANGE when clients are kicked for invalid credentials.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100