PrismarineJS / PrismarineJS/node-minecraft-protocol

mc.createClient doesnt check for SRV dns records

Open
#1,298 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

possible bug
Dominant language
JavaScript
Stars
1.4k
Forks
290
Avg merge
4d 8h
Merged PRs (30d)
7

Description

[x] The FAQ doesn't contain a resolution to my issue

Versions

  • minecraft-protocol: 1.20.2
  • server: paper 1.20.2
  • node: 21.7.2

Detailed description of a problem

mc.createClient doesnt check for SRV dns records
i have an A record set to X ip, and an SRV record set to Y ip. if i set mc.createClient({host: "my domain" ...}), it tries to connect to X instead of Y

Current code

const client = mc.createClient({
        host: host,
        port: port,
        username: "funny"
});

Expected behavior

connection to Y ip

Additional context

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the mc.createClient entry point and trace how the host and port are resolved before connecting. Verify the behavior with a domain that has both A and SRV records, and consider the work complete when the client connects to the SRV target Y rather than the A-record target X.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.