PrismarineJS / PrismarineJS/node-minecraft-data
isNewerOrEqualTo throws TypeError when comparing 2 different version types
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 127
- Forks
- 76
- Avg merge
- 7m
- Merged PRs (30d)
- 3
Description
E.g when you're trying to compare PE version with PC one
It should probably just return false instead
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the isNewerOrEqualTo implementation and reproduce the comparison between PE and PC versions. Trace where the differing version types cause the TypeError; done means the comparison returns false instead, with the existing test setup covering this case if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100